Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pie empty placeholder #2816

Merged

Conversation

FunctionEurus
Copy link
Contributor

@FunctionEurus FunctionEurus commented Jun 15, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

#1156

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

添加了emptyPlaceholder配置项,包含showEmptyCircle和emptyCircle,用于在未提供data.values或其为空时显示占位圆或其他占位图形(to be added)。

占位圆样式的设置:

emptyPlaceholer: {
    showEmptyCircle: true,
    emptyCircle: {
        style: {
            fill: "#66ccff"
        }
    }
}

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@xiaoluoHe xiaoluoHe changed the base branch from develop to dev/1.12.0 June 18, 2024 03:45
@xiaoluoHe
Copy link
Contributor

rebase 一下 dev/1.12.0 分支吧,新功能就不跟 patch 版本了

@github-actions github-actions bot added the docs label Jun 25, 2024
@xile611
Copy link
Contributor

xile611 commented Jun 27, 2024

@FunctionEurus #2863
数据全为0展示均匀扇区的需求,我建了独立的issue
也可以认领~
需要稍微修改这里的占位圆逻辑

@FunctionEurus
Copy link
Contributor Author

@FunctionEurus #2863 数据全为0展示均匀扇区的需求,我建了独立的issue 也可以认领~ 需要稍微修改这里的占位圆逻辑

为了修改此处的占位圆逻辑我先添加了stillShowZeroSum的接口,但并未实现这个feature,不知道这样处理是否合适。

@xile611
Copy link
Contributor

xile611 commented Jul 1, 2024

@FunctionEurus #2863 数据全为0展示均匀扇区的需求,我建了独立的issue 也可以认领~ 需要稍微修改这里的占位圆逻辑

为了修改此处的占位圆逻辑我先添加了stillShowZeroSum的接口,但并未实现这个feature,不知道这样处理是否合适。

@FunctionEurus 问题不大,全为0的可以在1.12.0分支提交就行

@FunctionEurus
Copy link
Contributor Author

@FunctionEurus #2863 数据全为0展示均匀扇区的需求,我建了独立的issue 也可以认领~ 需要稍微修改这里的占位圆逻辑

为了修改此处的占位圆逻辑我先添加了stillShowZeroSum的接口,但并未实现这个feature,不知道这样处理是否合适。

@FunctionEurus 问题不大,全为0的可以在1.12.0分支提交就行

好w,在这个pr里#2893

Copy link
Contributor

@youngwinds youngwinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@youngwinds youngwinds merged commit f469197 into VisActor:dev/1.12.0 Jul 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants