feat: More fmt improvements #224
Open
+296
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for newlines before curly braces in rule declaration. If "true" it will ensure at most 2 newlines exist before the opening curly brace. If zero newlines exist it will insert only one, but if 2 or more exist it will reduce it to exactly 2. The default for this is "false".
Add support for empty lines before/after section headers to the formatter.
This allows you to have rules like:
```
rule a {
meta:
foo = "bar"
condition:
true
}
```
Or various combinations of empty lines before/after. It is currently a boolean
option so if you only want it for a specific section we don't support that.
This fixes the case where you have: ``` meta: foo = "bar" baz = "pants" ``` Now each meta definition will go on a separate line. I originally thought this was broken by my work in this branch but it was just never implemented in main.
|
This is more work for #192 - if this is merged I'll follow-up with tests that handle all the options added so far. The formatter is starting to get more complicated with these options and I want to make sure we have good test coverage to help ensure proper functionality as I continue to work on the other requested features. |
plusvic
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for optional newline before curly brace in the rule declaration.
vs
It also adds support for empty lines before and after section headers. Each one is a separate option - you can have them before section headers but not after, vice versa, both, or none.
vs
This also fixes an issue where we were not inserting newlines before meta definitions, so if you had two meta definitions on the same line the formatter left them like that. They are now fixed so that each meta definition goes on a separate line.