Don't download test bridges and supported Scala version listing for pure Java projects #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
reviewed
May 5, 2022
Gedochao
approved these changes
May 6, 2022
This computes BuildOptions.projectParams early, which itself relies on BuildOptions.scalaParams, which downloads the supported Scala version listing. For pure Java projects, we'd rather not have this file be downloaded. Later on, BuildOptions are tweaked, so that BuildOptions.scalaParams doesn't try to download a version listing, for pure Java projects.
These are usually Scala dependencies, so are a problem in pure Java projects.
alexarchambault
force-pushed
the
no-scala-version-listing-pure-java
branch
from
0b6e7f8
to
1d0e5ac
Compare
|
(last force push: rebase on latest main + add comment in test in last commit) |
lwronski
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.