Define valid package type for Scala.js and Scala Native #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
valid-package-type
branch
2 times, most recently
from
460295f
to
cac4cc0
Compare
lwronski
force-pushed
the
valid-package-type
branch
from
cac4cc0
to
9a7aaed
Compare
romanowski
requested changes
Apr 26, 2022
I created new issue to implement some global mechanism for option checking - #941 (review) |
romanowski
approved these changes
Apr 26, 2022
| for (basePackageType <- basePackageTypeOpt) | ||
| yield | ||
| if (validPackageScalaJS.contains(basePackageType)) basePackageType | ||
| else throw new MalformedCliInputError( |
There was a problem hiding this comment.
As much as possible, we shouldn't throw here, but rather try to make the exception be returned via the left side of the either. Thrown exceptions aren't reported as nicely as the ones we propagate via eithers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept valid package type for Scala.js and Scala.Native, in other case throws error.
For example following command should generate
test.jarfile:Closed #915