Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start repl with scalac options #868

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Start repl with scalac options #868

merged 1 commit into from
Apr 12, 2022

Conversation

romanowski
Copy link
Member

@romanowski romanowski commented Apr 9, 2022 •
edited
Loading

Add test to make sure that we pass options to repl correctly.

This fixes regression in #738

@alexarchambault
Copy link
Contributor

(Looking at the current main code, it seems options.notForBloopOptions.replOptions.ammoniteArgs shouldn't be added either when options.notForBloopOptions.replOptions.useAmmonite is false…)

@romanowski
Start repl with scalac options
08c2785 
Add test to make sure that we pass options to repl correctly.
@romanowski romanowski merged commit 7e92b92 into VirtusLab:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanowski @alexarchambault