Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve latest version for --cli-version #827

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Resolve latest version for --cli-version #827

merged 2 commits into from
Apr 5, 2022

Conversation

lwronski
Copy link
Contributor

No description provided.

romanowski
romanowski requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is a draft but it looks good already!

I only miss tests and changes in docs

modules/cli/src/main/scala/scala/cli/launcher/LauncherCli.scala Outdated Show resolved Hide resolved
@lwronski lwronski force-pushed the latest-cli-version branch 2 times, most recently from 34dc4e9 to d1ec0c6 Compare April 5, 2022 11:58
@lwronski
Copy link
Contributor Author

lwronski commented Apr 5, 2022

I added CoursierUtil because I don't have access to WebPage.listDirectories which is declared as a private package:

private[coursier] object WebPage extends WebPageCompatibility {

@lwronski lwronski marked this pull request as ready for review April 5, 2022 12:26
alexarchambault
alexarchambault reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comments, LGTM!

modules/cli/src/main/scala/coursier/CoursierUtil.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/launcher/LauncherCli.scala Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/launcher/LauncherCli.scala Outdated Show resolved Hide resolved
@lwronski lwronski enabled auto-merge (squash) April 5, 2022 13:45
@lwronski lwronski merged commit 328d0d6 into VirtusLab:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@romanowski romanowski Awaiting requested review from romanowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @romanowski @alexarchambault