No strict bloop check in build #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
no-strict-bloop-check-in-build
branch
from
a269cd4
to
04828ef
Compare
When --strict-bloop-json-check=false was passed, it seems we were not updating Bloop files when new sources we added (or former ones removed). This should fix that.
This option should speed up compilation, by short-circuiting costly Bloop file generation when the build is apparently the same. As of now, this option doesn't overwrite the Bloop files when new sources are created, which is a problem.
alexarchambault
force-pushed
the
no-strict-bloop-check-in-build
branch
from
d765fb0
to
e3f7e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks things related to the
--strict-bloop-json-check=falseoption. This option basically short-circuits the (sometimes costly) checks for changes in Bloop config files written by Scala CLI. It was enabled in the Scala CLI build itself, but it seems it doesn't take into account new source files (it doesn't update Bloop config files when a new source file is added).This PR fixes that, and also disables
--strict-bloop-json-check=falsein the build for now, until we can benefit from the fix in the build.