-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish command #707
Merged
Merged
Add publish command #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
alexarchambault
force-pushed
the
publish
branch
5 times, most recently
from
February 27, 2022 21:53
3f9c2f5
to
b74b3bf
Compare
alexarchambault
force-pushed
the
publish
branch
from
February 28, 2022 11:25
b74b3bf
to
f99126d
Compare
Get the launcher path via Mill, so that it's fine if the paths returned by Mill change (happened with Mill 0.10.0 recently). Use cli.launcher rather than cli.standaloneLauncher, the former is faster to generate.
alexarchambault
force-pushed
the
publish
branch
from
February 28, 2022 15:18
f99126d
to
30382da
Compare
CI is green, but the Windows launcher takes quite a long time to generate. Seems we're a bit short on memory again :/
|
Might give the hosted Windows runner another try… |
alexarchambault
force-pushed
the
publish
branch
from
February 28, 2022 19:38
30382da
to
d8722cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.