Avoid compiling scope test for package/run/ commands #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
test-scope-compile
branch
5 times, most recently
from
7cf7bb4
to
4b4237e
Compare
lwronski
force-pushed
the
test-scope-compile
branch
from
4b4237e
to
99e701f
Compare
There was a problem hiding this comment.
We may want to ensure that --class-path makes compile print the full test scope class path, rather than the main one, when --test is passed.
For later: maybe the new CLI option could be moved to CompileCrossOptions. That would make most commands accept it, but we'd have to think about how each of them should use it (repl could put test classes in the class path, publish would publish test JARs alongside the main ones, test could even only look for tests in the main scope if --test=false is passed, etc.)
modules/cli/src/main/scala/scala/cli/commands/SharedOptions.scala
Outdated
Show resolved
Hide resolved
lwronski
force-pushed
the
test-scope-compile
branch
2 times, most recently
from
76a3846
to
00cdc4c
Compare
lwronski
force-pushed
the
test-scope-compile
branch
from
00cdc4c
to
7d27fc5
Compare
modules/integration/src/test/scala/scala/cli/integration/CompileTestDefinitions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/CompileTestDefinitions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/CompileTestDefinitions.scala
Outdated
Show resolved
Hide resolved
lwronski
requested review from
alexarchambault
and removed request for
alexarchambault
lwronski
force-pushed
the
test-scope-compile
branch
from
958c198
to
1697347
Compare
lwronski
force-pushed
the
test-scope-compile
branch
from
1697347
to
2c3daca
Compare
alexarchambault
approved these changes
Feb 17, 2022
romanowski
pushed a commit
to romanowski/scala-cli
that referenced
this pull request
Mar 10, 2022
* Avoid compiling scope test for package/run/ * Print fullClassPath from test if someone pass --class-path * Remove shouldCompileTest from BuildOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.