Shebang args #410
Merged
Shebang args #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpasternak
force-pushed
the
shebang-args
branch
from
c2d85d6
to
1eea6f1
Compare
tpasternak
force-pushed
the
shebang-args
branch
2 times, most recently
from
59b888f
to
4a9e910
Compare
tpasternak
force-pushed
the
shebang-args
branch
from
4a9e910
to
23fb2ea
Compare
tpasternak
force-pushed
the
shebang-args
branch
2 times, most recently
from
102eae9
to
5f23e44
Compare
tpasternak
force-pushed
the
shebang-args
branch
from
5f23e44
to
8e8514c
Compare
Comment on lines
195
to
197
| def programArgs(args: RemainingArgs) = args.unparsed | ||
|
|
||
| def inputArgs(args: RemainingArgs) = args.remaining |
There was a problem hiding this comment.
NIT Do we really need those methods? They don't use any of the fields of SharedOptions, are single-line, and are only called twice. Couldn't they just be inlined?
| final case class ShebangOptions( | ||
| @Recurse | ||
| runOptions: RunOptions = RunOptions() | ||
| ) {} |
There was a problem hiding this comment.
NIT
Suggested change
| ) {} | |
| ) |
|
|
||
| import caseapp._ | ||
|
|
||
| final case class ShebangOptions( |
There was a problem hiding this comment.
NIT Could ShebangOptions be moved to its own file (ShebangOptions.scala), like we do for all other classes?
tpasternak
force-pushed
the
shebang-args
branch
2 times, most recently
from
09cfe00
to
2144587
Compare
When running shebang files, the system constructs a command from by concatenating shebang line, input file name and program arguments. This means we need a special parsing mode that would accept only a single input, and treat everything that comes after the input as program arguments
tpasternak
force-pushed
the
shebang-args
branch
from
2144587
to
06ceb41
Compare
alexarchambault
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.