Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Add multimodule support to Scala CLI ⚠️ #3085

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

[PoC] Add multimodule support to Scala CLI ⚠️ #3085

wants to merge 36 commits into from

Commits on Aug 20, 2024

  1. Nit: Add named arguments to a buildOnce call

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    bb88e70 View commit details
    Browse the repository at this point in the history

  2. Remove maybeUpdateProjectTargetUri as ProjectName always has targetUr… 

    …iOpt set
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    bfe96df View commit details
    Browse the repository at this point in the history

  3. Fix CI on the fork not working

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f121b9a View commit details
    Browse the repository at this point in the history

  4. Remove argument that is same as default

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f5e1838 View commit details
    Browse the repository at this point in the history

  5. NIT: Just to make reviewing easier: 

    - copy HasGeneratedSources.scala into ManagesBuildTargets.scala
- copy HasGeneratedSourcesImpl.scala into ManagesBuildTargetsImpl.scala.
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fd5764d View commit details
    Browse the repository at this point in the history

  6. Change HasGeneratedSources to ManagesBuildTargets 

    Use ProjectName class instead of plain String
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fcbfa20 View commit details
    Browse the repository at this point in the history

  7. Add BspClient to the BspServer constructor arguments

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e4a5af3 View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5dc9811 View commit details
    Browse the repository at this point in the history

  9. [FIXME] Comment out broken tests hehe

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    68a755d View commit details
    Browse the repository at this point in the history

  10. Rename Inputs to ModuleInputs

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2326b64 View commit details
    Browse the repository at this point in the history

  11. Fix ProjectName with test scope

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ef8e672 View commit details
    Browse the repository at this point in the history

  12. Add InputsComposer for reading .toml file and creating a sequence of … 

    …inputs for further processing
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    88ab51c View commit details
    Browse the repository at this point in the history

  13. Force uniform workspace in module inputs

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    226b269 View commit details
    Browse the repository at this point in the history

  14. Use InputsComposer in Bsp

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f1d4d97 View commit details
    Browse the repository at this point in the history

  15. Add tests for InputsComposer

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d0d8a51 View commit details
    Browse the repository at this point in the history

  16. Force baseProjectName in InputsComposer

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4949fd9 View commit details
    Browse the repository at this point in the history

  17. Compose inputs in SetupIde, add fixes to Bsp initial configuration

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    31b041c View commit details
    Browse the repository at this point in the history

  18. Add classes dir of module dependencies to the project's classpath

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d7edb07 View commit details
    Browse the repository at this point in the history

  19. Add tests for multi module bsp

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3fcd3cb View commit details
    Browse the repository at this point in the history

  20. Apply scalafmt

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d51eeba View commit details
    Browse the repository at this point in the history

  21. Remove fixed TODO

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3e283f3 View commit details
    Browse the repository at this point in the history

  22. Remove unused val

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    12acd54 View commit details
    Browse the repository at this point in the history

  23. Add mechanism for picking the highest java version for bloop, add doc… 

    …s, add fixme
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    46481db View commit details
    Browse the repository at this point in the history

  24. WIP add Inputs trait and implementing classes

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7163000 View commit details
    Browse the repository at this point in the history

  25. Move some test code to utils class

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f9982c6 View commit details
    Browse the repository at this point in the history

  26. Implement a new trait Inputs, that aggregates ModuleInputs

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e4bf035 View commit details
    Browse the repository at this point in the history

  27. Rename ModuleInputs to Module

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1d04597 View commit details
    Browse the repository at this point in the history

  28. Revert adding options from sources to module hash as it's unnecessary… 

    … and complicates the build process in compose mode.
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5149426 View commit details
    Browse the repository at this point in the history

  29. Apply formatting

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0891684 View commit details
    Browse the repository at this point in the history

  30. Use InputsComposer in run command, add simple test

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2246a45 View commit details
    Browse the repository at this point in the history

  31. Fix after rebase

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    52fe31c View commit details
    Browse the repository at this point in the history

  32. Apply formatting

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    830ab30 View commit details
    Browse the repository at this point in the history

  33. Use common sense options in Bsp operations, change test that fails, b… 

    …ut in reality does not test anything with the last call to compile.
    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fa62f9a View commit details
    Browse the repository at this point in the history

  34. Fix tests and root cause of commons sense options passing not working

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0d8d01f View commit details
    Browse the repository at this point in the history

  35. WIP

    @MaciejG604
    MaciejG604 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f754c15 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add ComposeBuild, correctly combine classpaths of modules that have d… 

    …ependencies, WIP - test still needs fixing
    @MaciejG604
    MaciejG604 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    812bce1 View commit details
    Browse the repository at this point in the history