Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala to pure Java test builds #3009

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Jul 9, 2024

Fixes #2940

We generally don't add Scala to pure Java builds to keep them clean. Unfortunately, we do not have a pure Java test runner at the moment, so we still need Scala to run tests properly.

@Gedochao Gedochao force-pushed the maintenance/fix-pure-java-tests branch from 5afdf85 to a2add5f Compare July 9, 2024 07:41
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. Can't we use Bloop in that case? It should work correctly without Scala

@Gedochao
Copy link
Contributor Author

Gedochao commented Jul 9, 2024

Btw. Can't we use Bloop in that case? It should work correctly without Scala

might be worth a try... I'll check in a separate PR

@Gedochao Gedochao merged commit 63b4748 into VirtusLab:main Jul 9, 2024
75 checks passed
@Gedochao Gedochao deleted the maintenance/fix-pure-java-tests branch July 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala CLI fails to run tests for a pure Java project
2 participants