Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update case-app to 2.1.0-M29 #2964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates com.github.alexarchambault:case-app from 2.1.0-M28 to 2.1.0-M29

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.github.alexarchambault", artifactId = "case-app" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.alexarchambault", artifactId = "case-app" }
}]
labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

@Gedochao
Copy link
Contributor

@alexarchambault @corey-at-protenus
Do you have any idea what could be broken here?
I'm currently suspecting the help (and thus, initialisation of sub-commands) is broken because of the changes in alexarchambault/case-app#483, but I don't quite understand the root cause.

cli.tests.HelpCheck.help message should be shorter then 80 lines  0.163s java.lang.ExceptionInInitializerError: null
    at scala.cli.ScalaCliCommands.allCommands(ScalaCliCommands.scala:26)
    at scala.cli.ScalaCliCommands.commands(ScalaCliCommands.scala:67)
    at caseapp.core.app.CommandsEntryPoint.help(CommandsEntryPoint.scala:29)
    at scala.cli.ScalaCliCommands.help$lzyINIT1(ScalaCliCommands.scala:88)
    at scala.cli.ScalaCliCommands.help(ScalaCliCommands.scala:87)
    at cli.tests.HelpCheck.$init$$$anonfun$1(HelpCheck.scala:12)
    at munit.internal.console.StackTraces$.dropOutside(StackTraces.scala:12)
    at munit.ValueTransforms.$anonfun$3(ValueTransforms.scala:37)
    at scala.util.Try$.apply(Try.scala:217)
    at munit.ValueTransforms.munitValueTransform(ValueTransforms.scala:37)
    at munit.ValueTransforms.munitValueTransform$(ValueTransforms.scala:8)
    at munit.FunSuite.munitValueTransform(FunSuite.scala:11)
    at munit.BaseFunSuite.test$$anonfun$1$$anonfun$1(FunSuite.scala:37)
    at munit.internal.PlatformCompat$$anon$3.run(PlatformCompat.scala:69)
    at munit.Suite$$anon$1.execute(Suite.scala:28)
    at munit.internal.PlatformCompat$.waitAtMost(PlatformCompat.scala:74)
    at munit.BaseFunSuite.waitForCompletion(FunSuite.scala:51)
    at munit.BaseFunSuite.test$$anonfun$1(FunSuite.scala:37)
    at munit.MUnitRunner.$anonfun$6$$anonfun$1(MUnitRunner.scala:347)
    at munit.internal.console.StackTraces$.dropOutside(StackTraces.scala:12)
    at munit.MUnitRunner.$anonfun$6(MUnitRunner.scala:347)
    at scala.concurrent.impl.Promise$Transformation.run(Promise.scala:470)
    at munit.Suite$$anon$1.execute(Suite.scala:28)
    at scala.concurrent.impl.Promise$Transformation.submitWithValue(Promise.scala:429)
    at scala.concurrent.impl.Promise$DefaultPromise.submitWithValue(Promise.scala:338)
    at scala.concurrent.impl.Promise$DefaultPromise.dispatchOrAddCallbacks(Promise.scala:312)
    at scala.concurrent.impl.Promise$DefaultPromise.flatMap(Promise.scala:176)
    at munit.MUnitRunner.runTestBody(MUnitRunner.scala:357)
    at munit.MUnitRunner.runTest(MUnitRunner.scala:324)
    at munit.MUnitRunner.runTests$$anonfun$1(MUnitRunner.scala:140)
    at scala.collection.Iterator$$anon$9.next(Iterator.scala:584)
    at munit.MUnitRunner.loop$1(MUnitRunner.scala:155)
    at munit.MUnitRunner.sequenceFutures(MUnitRunner.scala:168)
    at munit.MUnitRunner.runTests(MUnitRunner.scala:140)
    at munit.MUnitRunner.runAll$$anonfun$1(MUnitRunner.scala:188)
    at scala.concurrent.impl.Promise$Transformation.run(Promise.scala:470)
    at munit.Suite$$anon$1.execute(Suite.scala:28)
    at scala.concurrent.impl.Promise$Transformation.submitWithValue(Promise.scala:429)
    at scala.concurrent.impl.Promise$DefaultPromise.submitWithValue(Promise.scala:338)
    at scala.concurrent.impl.Promise$DefaultPromise.dispatchOrAddCallbacks(Promise.scala:312)
    at scala.concurrent.impl.Promise$DefaultPromise.flatMap(Promise.scala:176)
    at munit.MUnitRunner.runAll(MUnitRunner.scala:194)
    at munit.MUnitRunner.runAsync(MUnitRunner.scala:126)
    at munit.MUnitRunner.run(MUnitRunner.scala:121)
    at munit.internal.junitinterface.JUnitRunnerWrapper.run(JUnitRunnerWrapper.java:24)
    ...
Caused by: java.lang.NullPointerException: Cannot invoke "caseapp.core.help.Help.progName()" because the return value of "caseapp.core.app.CaseApp.help()" is null
    at caseapp.core.app.CaseApp.name(CaseApp.scala:14)
    at scala.cli.commands.ScalaCommand.actualCommandName$$anonfun$2(ScalaCommand.scala:86)
    at scala.Option.getOrElse(Option.scala:201)
    at scala.cli.commands.ScalaCommand.actualCommandName(ScalaCommand.scala:86)
    at scala.cli.commands.ScalaCommand.<init>(ScalaCommand.scala:290)
    at scala.cli.commands.addpath.AddPath$.<init>(AddPath.scala:13)
    at scala.cli.commands.addpath.AddPath$.<clinit>(AddPath.scala:13)
    ... 65 more

Any clue?

@Gedochao
Copy link
Contributor

It seems the parser won't initialise if @Recurse is present...

Exception in thread "main" java.lang.NoClassDefFoundError: caseapp/Recurse$
        at scala.cli.commands.shared.LoggingOptions$.parser$lzyINIT1(LoggingOptions.scala:33)
        at scala.cli.commands.shared.LoggingOptions$.parser(LoggingOptions.scala:33)
        at scala.cli.commands.shared.GlobalOptions$.parser$lzyINIT1(GlobalOptions.scala:21)
        at scala.cli.commands.shared.GlobalOptions$.parser(GlobalOptions.scala:21)
        at scala.cli.commands.addpath.AddPathOptions$.parser$lzyINIT1(AddPathOptions.scala:19)
        at scala.cli.commands.addpath.AddPathOptions$.parser(AddPathOptions.scala:19)
        at scala.cli.commands.addpath.AddPath$.<init>(AddPath.scala:13)
        at scala.cli.commands.addpath.AddPath$.<clinit>(AddPath.scala:13)
        at scala.cli.ScalaCliCommands.allCommands(ScalaCliCommands.scala:26)
        at scala.cli.ScalaCliCommands.commands(ScalaCliCommands.scala:67)
        ...

@corey-at-protenus
Copy link

corey-at-protenus commented Jun 26, 2024 via email

@coreyoconnor
Copy link
Contributor

Reproduced locally (This is @corey-at-protenus 's main account).

@coreyoconnor
Copy link
Contributor

Ok. There are other problems with recurse. Modifying the Formatter does not seem correct. I'll need a re-think on this feature. For now I propose reverting the prefix addition: alexarchambault/case-app#555

@coreyoconnor
Copy link
Contributor

This PR can be closed. The update was included in #3152 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants