-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky completions for zsh
#2118
Conversation
quotes break zsh completions
Hey, thanks for the contribution!
(
(adding a Is this the behaviour you're trying to fix? |
We might need to add a relevant anti-regression test. Do you have the time to add a test? |
the You can fix it by running ./mill -i generate-reference-doc.run (as per CONTRIBUTING.md) |
Indeed, once you manage to limit the output to completions that don't contain quotes in their description it works.
Yes that's exactly it. Turns out a similar change has already been attempted in the past #893
I will give it a go. I just noticed that completions are implemented by case-app instead of natively in scala-cli. I should probably open an issue there. |
|
ab4f1b2
to
bee2401
Compare
modules/integration/src/test/scala/scala/cli/integration/CompleteTests.scala
Outdated
Show resolved
Hide resolved
…eteTests.scala Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Quotes break zsh completions.
Or more specifically, escaped quotes
\'
seem to break completions on zsh.