Cleanup version, about & doctor sub-commands
#1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
added
the
SIP-46
Gedochao
force-pushed
the
version-about-doctor-cleanup
branch
3 times, most recently
from
3a9a9b4
to
c1dcbc1
Compare
Gedochao
force-pushed
the
version-about-doctor-cleanup
branch
from
14a5137
to
239394d
Compare
lwronski
approved these changes
Jan 4, 2023
modules/cli/src/main/scala/scala/cli/commands/version/VersionOptions.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
Fixes #1667
Closes #698
in accordance with #1665 (comment), this does the following:
doctorsub-command is being removed, its present and previously planned functionalities should be delivered in a more interactive manneraboutsub-command is being removed, its functionalities merged intoversionversionwill now check if Scala CLI is up-to-date (similarly how it was previously done inabout)--offlineoption was added toversionto allow to skip checking if Scala CLI is up-to-date--scala-versionand--cli-versionoptions similarly skip checking if Scala CLI is up-to-date, outputting just the raw version requested