Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suffix .aux from progName when installed by cs #1736

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Remove suffix .aux from progName when installed by cs #1736

merged 1 commit into from
Jan 2, 2023

Conversation

lwronski
Copy link
Contributor

Fixes #1662.

@lwronski lwronski force-pushed the fix-usage-path-scala branch 3 times, most recently from 958f845 to 1119dba Compare December 28, 2022 13:51
@lwronski lwronski requested review from julienrf and tgodzik and removed request for julienrf December 28, 2022 13:52
@lwronski lwronski force-pushed the fix-usage-path-scala branch 2 times, most recently from 292967f to a18188d Compare December 28, 2022 15:07
julienrf
julienrf approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Łukas!

Gedochao
Gedochao approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/cli/src/main/scala/scala/cli/ScalaCli.scala Outdated Show resolved Hide resolved
@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Jan 2, 2023
@lwronski lwronski enabled auto-merge (squash) January 2, 2023 12:07
@lwronski lwronski merged commit e368529 into VirtusLab:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

@Gedochao Gedochao Gedochao approved these changes

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees
No one assigned
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing path shown in --usage output
4 participants
@lwronski @julienrf @tgodzik @Gedochao