Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to circumvent Scala version checks #1730

Closed

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Dec 23, 2022

Just in case. Having issues with it with locally published Scala versions right now, so I'd rather disable this check if I can.

Needs scalacenter/bloop-config#20, scala-cli/bloop-core#129

@alexarchambault alexarchambault force-pushed the force-scala-version branch 2 times, most recently from 6db2401 to ded845b Compare January 23, 2023 11:59
@tgodzik
Copy link
Member

tgodzik commented Jan 23, 2023

Just in case. Having issues with it with locally published Scala versions right now, so I'd rather disable this check if I can.

Needs scalacenter/bloop-config#20, scala-cli/bloop-core#129

What is the issue you are getting? It should work correctly for locally published jars, last time I checked the correct bridge was used if available.

@alexarchambault
Copy link
Contributor Author

alexarchambault commented Jan 23, 2023

What is the issue you are getting? It should work correctly for locally published jars, last time I checked the correct bridge was used if available.

Precisely, bridges are fetched by Bloop from the default coursier repositories, so ~/.ivy2/local and Maven Central. For reproducibility, we use a custom repo in an arbitrary directory in the test added here. Having Bloop accept the bridge JAR alongside the compiler JARs allows to get that bridge JAR via the custom repo, that the build tool (Scala CLI) knows about, while Bloop doesn't.

Note also that for Scala 3, the bridge JAR originates from the same organization as the compiler, and has the same version too. In essence, it feels like it's part of the compiler - so why should it be handled differently than the compiler JARs?

@alexarchambault
Copy link
Contributor Author

Just moved the non-regression test, along with the Bloop-related changes it requires, to #1889

@alexarchambault alexarchambault marked this pull request as ready for review February 27, 2023 14:11
Just in case. Having issues with locally published Scala versions right
now, so I'd rather not have this check.
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add docs how to avoid Scala version checks? It might be useful for Nix environment.

@Gedochao
Copy link
Contributor

Gedochao commented Oct 5, 2023

Closing this for now, as there's been no activity neither here nor in the prerequisite PRs for a long while.
Feel free to reopen if you continue working on this.
Progress is to be tracked under #2447.

@Gedochao Gedochao closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants