Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set page size for aarch64 Linux binaries to 64k #1726

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Dec 23, 2022

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz Thanks a lot for your contribution. I think we can merge it when you get the final confirmation from oracle - #1714 (comment).

@mkurz
Copy link
Contributor Author

mkurz commented Dec 23, 2022

@lwronski It's official now! We have green light both from the GraalVM team (oracle/graal#5605 (comment)) and from CI 😉
Please merge 👍

@lwronski
Copy link
Contributor

lwronski commented Dec 23, 2022

@lwronski It's official now! We have green light both from the GraalVM team (oracle/graal#5605 (comment)) and from CI 😉
Please merge 👍

@mkurz Now I'm thinking about page size. Should we use 64k size, maybe 16k will be enough? do you know any system that uses 64k? cc: @alexarchambault

@mkurz
Copy link
Contributor Author

mkurz commented Dec 23, 2022

@lwronski Like said, I am not an expert in this field, just what I read on the internet now. For me it seems most Linux distributions come with 4kb page size kernels, and mine with 16k. It seems 64k is very unusual. It's up to you if you want to use 16k or 64k. If you use 16k, at least you know what the problem could be if someone comes up with a bug report that sounds like Fatal error: Failed to create the main Isolate., in such a case you can still adjust the page size for an upcoming release then.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so let's merge this PR. Thanks for help!

@lwronski lwronski merged commit 2f5393f into VirtusLab:main Dec 23, 2022
@mkurz mkurz deleted the aarch64_linux_pagesize_64k branch December 23, 2022 16:57
@Gedochao Gedochao added the bug Something isn't working label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux aarch64 not working under Asahi Linux (Apple Silicon M1)
3 participants