Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scala to 2.12.16 #1099

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Update Scala to 2.12.16 #1099

merged 4 commits into from
Jun 14, 2022

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault mentioned this pull request Jun 13, 2022
Merged
@lwronski
Copy link
Contributor

Test fail, because latest supported scala version is set to 2.12.15, therefore scala prefix 2.12 is resolved to 2.12.15.

Maybe we should remove this test use expected default scala version for prefix scala version: 2.12 and test it only from conf file as here

@alexarchambault
Copy link
Contributor Author

Merging VirtusLab/scala-cli-scala-versions#4 should make that test pass (and proceeding this way overall - bumping in scala-cli-scala-versions, then here - looks fine I guess).

@alexarchambault alexarchambault marked this pull request as ready for review June 14, 2022 08:28
@alexarchambault alexarchambault merged commit 05de912 into VirtusLab:main Jun 14, 2022
@alexarchambault alexarchambault deleted the scala-2.12.16 branch June 14, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @lwronski @Gedochao