Convert relative path to absolute for coverage options #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Shouldn't we do that only when using Bloop, just in case? It could be handled around here, right before we write a Bloop file.
(Like if any of the options starts with -coverage-out:, we parse the options again as a ShadowingSeq[ScalacOpt], and update the -coverage-out:… one)
lwronski
force-pushed
the
scoverage.coverage-fix
branch
from
f1bb055
to
6f57d72
Compare
lwronski
force-pushed
the
scoverage.coverage-fix
branch
from
6f57d72
to
1b6fac6
Compare
lwronski
force-pushed
the
scoverage.coverage-fix
branch
from
6da85d7
to
c0455de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.