Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external binary to extract class name from stdin Java sources #1068

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Use external binary to extract class name from stdin Java sources #1068

merged 4 commits into from
Jun 6, 2022

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault force-pushed the java-class-name-external-binary branch from 33e2df9 to fbe0643 Compare June 2, 2022 17:18
@alexarchambault alexarchambault changed the title Use external binary to extract class name from stdin Java source Use external binary to extract class name from stdin Java sources Jun 2, 2022
@alexarchambault alexarchambault force-pushed the java-class-name-external-binary branch 2 times, most recently from 80a6ecf to de402e7 Compare June 2, 2022 17:28
@alexarchambault alexarchambault mentioned this pull request Jun 2, 2022
Closed
@alexarchambault alexarchambault marked this pull request as ready for review June 2, 2022 22:11
@alexarchambault

This comment was marked as resolved.

Sign in to view
@alexarchambault alexarchambault force-pushed the java-class-name-external-binary branch 2 times, most recently from 6103ed8 to 3c59117 Compare June 3, 2022 08:30
@alexarchambault alexarchambault mentioned this pull request Jun 3, 2022
Merged
@Gedochao
Copy link
Contributor

Gedochao commented Jun 6, 2022

I think it'd be useful to mention java-class-name among other libraries/forks we maintain ourselves in a separate .md doc, so that it's easier to look them up when contributing.

(unless we already have a doc like that? in which case java-class-name should be mentioned there)

@alexarchambault alexarchambault force-pushed the java-class-name-external-binary branch from 3c59117 to bfc96d6 Compare June 6, 2022 10:51
@alexarchambault
Copy link
Contributor Author

I think it'd be useful to mention java-class-name among other libraries/forks we maintain ourselves in a separate .md doc, so that it's easier to look them up when contributing.

To me, that doc is https://github.com/scala-cli

@Gedochao
Copy link
Contributor

Gedochao commented Jun 6, 2022

To me, that doc is https://github.com/scala-cli

Okay... but do we mention the scala-cli org anywhere in our docs?
You may be right that it's probably sufficient to make the list of repos there visible to our contributors

@alexarchambault
Copy link
Contributor Author

Okay... but do we mention the scala-cli org anywhere in our docs?

Just opened #1075 for it.

@alexarchambault alexarchambault merged commit 86bafce into VirtusLab:main Jun 6, 2022
@alexarchambault alexarchambault deleted the java-class-name-external-binary branch June 6, 2022 12:57
@lwronski lwronski mentioned this pull request Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexarchambault @Gedochao