-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance exploration #87
Conversation
…a into fix/inclusive-exploration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🤩. I only have one super minor comment about an info log message. Please address as you see fit and then feel free to merge 👍.
""" | ||
Extract relevant species names based on the user question. | ||
""" | ||
logger.info("Loading prompt for the LLM model.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more informative info message might be better e.g., including something about the arg_data
or state
along with the line number and function call that is included by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmccloskey
That’s a great point—the logging makes more sense after loading the config since it defines the prompt used by the LLM to return species with exact names based on the user’s question. I’ve updated it accordingly (y)
🎉 This PR is included in version 1.15.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 similar comments
🎉 This PR is included in version 1.15.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.15.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.15.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
For authors
Description
T2Bdemo9.mp4
In this PR, I'd like to introduce two key improvements to make the agent more exploration-friendly, catering to users who may not be familiar with a model and may nevertheless wish to explore its contents.
get_annotation
tool). Implemented structured LLM output parsing to extract species names from abstract queries.get_modelinfo
tool) returned only names. With this update, the agent can now also return initial concentration/value, compartment, and units for species and parameters.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.
tests
foldertests/testX.py
)Checklist
tests
folder) that prove my fix is effective or that my feature worksFor reviewers
Checklist pre-approval
Checklist post-approval
develop
intomain
? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.Checklist post-merge
develop
intomain
and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.