Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address reviews #108

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix: address reviews #108

merged 2 commits into from
Feb 25, 2025

Conversation

gurdeep330
Copy link
Member

@gurdeep330 gurdeep330 commented Feb 24, 2025

For authors

Description

In this PR, I'd implement feature requests/fix bug reports received from users:

  • load_biomodel utility: Extend support for BioModels starting with MODEL*.
  • search_models tool:
    • Replace markdown tables with dataframes.
    • Increase result limit to 100 (upper limit in basico).
  • Model handling: Fix support for models that don't return parameters (e.g., BioModel 10).
  • Plotly charts: Improve x/y axis labels to be more descriptive, including units.
  • steady_state tool: Display steady-state table instead of just a tool message.
  • Starter message: Add sample question on parameter scanning and annotations.

Fixes # (issue) NA

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.

  • Added new test(s) in the tests folder
  • Added new function(s) to an existing test(s) (e.g.: tests/testX.py)
  • No new tests added (Please explain the rationale in this case)

Checklist

  • My code follows the style guidelines mentioned in the Code/DevOps guides
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. MkDocs)
  • My changes generate no new warnings
  • I have added or updated tests (in the tests folder) that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For reviewers

Checklist pre-approval

  • Is there enough documentation?
  • If a new feature has been added, or a bug fixed, has a test been added to confirm good behavior?
  • Does the test(s) successfully test edge/corner cases?
  • Does the PR pass the tests? (if the repository has continuous integration)

Checklist post-approval

  • Does this PR merge develop into main? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.
  • Does this PR close an issue? If so, please make sure to descriptively close this issue when the PR is merged.

Checklist post-merge

  • When you approve of the PR, merge and close it (Read this article to know about different merge methods on GitHub)
  • Did this PR merge develop into main and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.

Copy link
Member

@dmccloskey dmccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes. I can't wait to try the one for the different biomodel starting ID strings 😉. I only had a few minor comments.

@gurdeep330
Copy link
Member Author

@dmccloskey Thank you for the review and all the suggestions. Let me know if anything is still missing.

Copy link
Member

@dmccloskey dmccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear 😊

@dmccloskey dmccloskey merged commit 191ace3 into main Feb 25, 2025
6 checks passed
@dmccloskey dmccloskey deleted the fix/implement-t2b-reviews branch February 25, 2025 09:21
Copy link
Contributor

🎉 This PR is included in version 1.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants