Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/568 #593

Merged
merged 19 commits into from
Jun 30, 2020
Merged

Feature/568 #593

merged 19 commits into from
Jun 30, 2020

Conversation

jrmartin
Copy link
Contributor

@jrmartin jrmartin commented Jun 9, 2020

Takes care of issue #568 . Branched from #567 , PR #574

@jrmartin jrmartin requested review from ddelpiano and Robbie1977 and removed request for ddelpiano June 9, 2020 23:35
@ddelpiano
Copy link
Contributor

@jrmartin overall good job, I noticed one issue though.
I load VFB (standard template VFB_00017894), add medulla, go to the graph, the graph displayed is synched with the focus term (until here all good).
Then I click on one of the nodes in the graph, I can see the instance is added but suddendly the spinner replace the graph and never disappear (or never reload the graph).
I don't expect the spinner to be there unless I click on the sync button.
This is exactly the workflow that I used, I think a simple click on one of the node of the graph will trigger the problem but I did not tried that.
If you have any question feel free to ping me.

Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug spotted (documented already).

@jrmartin
Copy link
Contributor Author

@jrmartin overall good job, I noticed one issue though.
I load VFB (standard template VFB_00017894), add medulla, go to the graph, the graph displayed is synched with the focus term (until here all good).
Then I click on one of the nodes in the graph, I can see the instance is added but suddendly the spinner replace the graph and never disappear (or never reload the graph).
I don't expect the spinner to be there unless I click on the sync button.
This is exactly the workflow that I used, I think a simple click on one of the node of the graph will trigger the problem but I did not tried that.
If you have any question feel free to ping me.

@ddelpiano Fixed with latest push

@Robbie1977 Robbie1977 dismissed ddelpiano’s stale review June 29, 2020 12:13

Fix requested done

@Robbie1977 Robbie1977 merged commit 61ec069 into development Jun 30, 2020
@ddelpiano ddelpiano deleted the feature/568 branch April 12, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants