Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-organizing components name and folder to be aligned with the same … #465

Merged
merged 3 commits into from
Dec 17, 2019
Merged

re-organizing components name and folder to be aligned with the same … #465

merged 3 commits into from
Dec 17, 2019

Conversation

ddelpiano
Copy link
Contributor

Functionally nothing new, just re-organized the code.

@ddelpiano
re-organizing components name and folder to be aligned with the same …
cfc53e1 
…(or as similar as possibile) naming convention
@ddelpiano ddelpiano requested a review from Robbie1977 December 9, 2019 10:40
@ddelpiano ddelpiano self-assigned this Dec 9, 2019
@ddelpiano
Copy link
Contributor Author

@Robbie1977 tests already passing https://travis-ci.org/VirtualFlyBrain/geppetto-vfb/builds/621695135

gidili
gidili approved these changes Dec 10, 2019
View reviewed changes
Copy link
Collaborator

@gidili gidili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only suggestion is to get rid of of requires if we can use imports (there's a lot of imports that look obsolete)

@Robbie1977 Robbie1977 merged commit 9e5e974 into development Dec 17, 2019
@Robbie1977 Robbie1977 mentioned this pull request Nov 4, 2022
Closed
@Robbie1977 Robbie1977 mentioned this pull request Dec 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gidili gidili gidili approved these changes

@Robbie1977 Robbie1977 Awaiting requested review from Robbie1977

Assignees

@ddelpiano ddelpiano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddelpiano @gidili @Robbie1977