-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree browser improvements #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleanup (might already have happened in subsequent commits, just double check)
components/interface/TreeWidget.js
Outdated
if (this.nodeWithColorPicker !== undefined) { | ||
this.nodeWithColorPicker.showColorPicker = false; | ||
this.nodeWithColorPicker = undefined; | ||
} | ||
this.colorPickerContainer = undefined; | ||
this.setState({ displayColorPicker: false }); | ||
break; | ||
default: | ||
console.log('mouse click function in the tree, just clicked this if you need'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddelpiano remove this?
components/interface/TreeWidget.js
Outdated
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddelpiano cleanup
@@ -471,7 +514,7 @@ export default class TreeWidget extends React.Component { | |||
aria-hidden="true" | |||
onClick={ e => { | |||
e.stopPropagation(); | |||
rowInfo.node.subtitle = rowInfo.node.instanceId; | |||
// rowInfo.node.subtitle = rowInfo.node.instanceId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddelpiano cleanup
For @Robbie1977, before to merge please be aware that this has been branched out from vfb_geppeto_application.