Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree browser improvements #461

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Tree browser improvements #461

merged 2 commits into from
Dec 5, 2019

Conversation

ddelpiano
Copy link
Contributor

  • working with the new query provided by @dosumis
  • a bit of factor out of code from the component to help the reading and understanding of the same.
  • select and delete events fixed.

For @Robbie1977, before to merge please be aware that this has been branched out from vfb_geppeto_application.

@Robbie1977 Robbie1977 changed the base branch from development to vfb_geppetto_application December 5, 2019 11:52
@Robbie1977 Robbie1977 merged commit ad35e05 into vfb_geppetto_application Dec 5, 2019
Copy link
Collaborator

@gidili gidili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup (might already have happened in subsequent commits, just double check)

if (this.nodeWithColorPicker !== undefined) {
this.nodeWithColorPicker.showColorPicker = false;
this.nodeWithColorPicker = undefined;
}
this.colorPickerContainer = undefined;
this.setState({ displayColorPicker: false });
break;
default:
console.log('mouse click function in the tree, just clicked this if you need');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano remove this?

}

/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano cleanup

@@ -471,7 +514,7 @@ export default class TreeWidget extends React.Component {
aria-hidden="true"
onClick={ e => {
e.stopPropagation();
rowInfo.node.subtitle = rowInfo.node.instanceId;
// rowInfo.node.subtitle = rowInfo.node.instanceId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano cleanup

@ddelpiano ddelpiano deleted the fix/458 branch April 12, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants