Tree browser #442
Tree browser #442
Conversation
ddelpiano
commented
Nov 4, 2019
•
ddelpiano
commented
- Cypher query factored out in configuration file
- change onClick behaviour, remove the i-info and if you click on label it will display on the term info, the arrows instead will drive the navigation.
- Label will show tooltip with the thumbnail, remove the info icon.
- vertical size of the boxes to be reduced.
- Color picker to be included.
- Checkbox to add individual to be added (eye icon to be in line with other components).
- expand on instance selection not working (works for classes, need to discuss this in the sprint)
- If focus term = Type or anat_ind -> open tree to corresponding node(s)
|
Just a reminder for the sprint call, the last checkbox is not marked since that feature works for classes or for individual (once they are loaded), however I can see this works for either of them when I select something from the stackviewer - I need to discuss this with @Robbie1977 to understand what's done in the stack to get individual and class in one shot since this will be beneficial also for the tree. |
Latest travis build setup from Development
This reverts commit 7258f57.
| @@ -1124,7 +1124,7 @@ | |||
| * Nodes matching the search conditions are highlighted | |||
| */ | |||
| .rst__rowSearchMatch { | |||
| outline: solid 3px #0080ff; | |||
| //outline: solid 3px #0080ff; | |||
There was a problem hiding this comment.
@ddelpiano remove if unused?
| onClick={ () => { | ||
| this.setState({ displayColorPicker: true }); | ||
| }}> | ||
| { (this.state.displayColorPicker |
There was a problem hiding this comment.
@ddelpiano ternary operator here makes the code hard to read, it's ok for short one-liners but in cases like this I would avoid it
| this.setState({ displayColorPicker: true }); | ||
| }}> | ||
| { (this.state.displayColorPicker | ||
| if (Instances[rowInfo.node.instanceId] !== undefined && typeof Instances[rowInfo.node.instanceId].isVisible !== "undefined") { |
There was a problem hiding this comment.
@ddelpiano too many nested if else else if else - very hard to read --> switch
| @@ -1615,10 +1615,12 @@ | |||
| } | |||
|
|
|||
| .nodeFound { | |||
| outline: solid 3px #0080ff; | |||
| //outline: solid 3px #0080ff; | |||
| var node = nodes[this.findChildren({ id: uniqNodes[j] }, "id", nodes)[0]]; | ||
| if (node.instanceId.indexOf("VFB_") > -1) { | ||
| child.instanceId = node.instanceId; | ||
| // child.subtitle = child.subtitle + " " + node.instanceId; |
There was a problem hiding this comment.
@ddelpiano cleanup if this is gone for real
