Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes clearall bug in focusterm #434

Merged
merged 7 commits into from
Oct 20, 2019
Merged

fixes clearall bug in focusterm #434

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4781ffd
fixes clearall bug in focusterm
jrmartin Oct 15, 2019
743c743
eslint fix
jrmartin Oct 15, 2019
524c788
add "test": "jest --verbose" package.json
jrmartin Oct 18, 2019
d358ad2
config changes for running jest tests
jrmartin Oct 18, 2019
7b8a9d3
add jest dependencies
jrmartin Oct 18, 2019
82a1dbb
remove -g flag from npm install in travis
jrmartin Oct 18, 2019
f1ea28e
Merge remote-tracking branch 'origin/development' into feature/218
jrmartin Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions components/interface/FocusTerm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,14 @@ export default class FocusTerm extends React.Component {
window.addVfbId(window[window.templateID].getId());
if (Instances[i].parent != null) {
Instances[i].parent.delete();
// Delete instance too after deleting parent
if (Instances[i] != null) {
Instances[i].delete()
}
} else {
Instances[i].delete()
}
i = i - 1; // Since an array element has been deleted, index is updated too
}
}
}
Expand Down