Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1173 - Contents Download Instances #1177

Closed
wants to merge 5 commits into from
Closed

Conversation

jrmartin
Copy link
Contributor

Component to download instances media contents, with new requirement to display list of all instances.

@jrmartin
Copy link
Contributor Author

Latest :
image

Copy link
Contributor

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncaught TypeError: Cannot read property 'values' of undefined
    at VFBDownloadContents.extractVariableFileMeta (VFBDownloadContents.js:91)
    at VFBDownloadContents.js:80
    at Array.map (<anonymous>)
    at VFBDownloadContents.handleDownload (VFBDownloadContents.js:79)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:306)
    at executeDispatch (react-dom.development.js:389)
    at executeDispatchesInOrder (react-dom.development.js:414)

To reproduce, load medulla in the scene, open the download content component, unselect the template and select only image type (first from the types on top).
Click download and you will see the issue.

@ddelpiano ddelpiano marked this pull request as ready for review August 23, 2021 18:15
@jrmartin jrmartin requested a review from ddelpiano August 23, 2021 18:57
@jrmartin
Copy link
Contributor Author

@ddelpiano Check for undefined/null objects added, the crash shouldn't happen anymore.

@ddelpiano
Copy link
Contributor

closing this since it will be delivered with feature/1181 entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants