Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of Template in 3D viewer #728

Closed
Robbie1977 opened this issue Oct 28, 2020 · 3 comments · Fixed by #1151
Closed

Selection of Template in 3D viewer #728

Robbie1977 opened this issue Oct 28, 2020 · 3 comments · Fixed by #1151
Assignees

Comments

@Robbie1977
Copy link
Contributor

Can we skip selecting the template and move to the next object down in the selected path as this sort of template selection is no longer needed.

@ddelpiano
Copy link
Contributor

@Robbie1977 what about the stack viewer?
this would not work on the canvas component itself but will re-use the logic already in place since we are storing in window.templateID the id that we should avoid the selection for and then wrap this logic around that instance id.

@ddelpiano ddelpiano assigned jrmartin and unassigned Robbie1977 and ddelpiano Jun 21, 2021
@jrmartin
Copy link
Contributor

jrmartin commented Jul 1, 2021

Hello @Robbie1977 , couple questions about this:

If the selection of the template is prevented in the 3D Viewer, the user will lose the ability to click the template in 3D Viewer and have the Term Info display the template's metadata. Is it okay to lose this feature? The user will have to have another way of selecting the template to view its metadata.

Also, if we prevent the selection of the template in the 3D Viewer, do we do the same in the Layers component and disable the selection/deselection controls for the template?

@Robbie1977
Copy link
Contributor Author

Happy to lose selection of the template as there are now plenty of ways to get to it and it's not usually something users want.

The slice viewer already prevents template selection.

The selection itself isn't the problem it's just that it gets in the way of selecting an item in 3D as it always the first thing hit which confuses users. In short the selection in Term Info. and the Layer tool can stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants