Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geppetto isKeypressed sticking when keyup event is 'off page'. #531

Closed
Robbie1977 opened this issue Feb 25, 2020 · 1 comment · Fixed by #1160
Closed

Geppetto isKeypressed sticking when keyup event is 'off page'. #531

Robbie1977 opened this issue Feb 25, 2020 · 1 comment · Fixed by #1160
Assignees
Labels
bug MetaCell Jobs for metacell

Comments

@Robbie1977
Copy link
Contributor

This issue has been flagged again and I think we need to implement either a timeout on a keypress (1 min after keydown) or a clear on page focus loss?

@Robbie1977 Robbie1977 added bug MetaCell Jobs for metacell labels Feb 25, 2020
@ddelpiano ddelpiano assigned jrmartin and unassigned ddelpiano Jun 21, 2021
@jrmartin
Copy link
Contributor

jrmartin commented Jul 2, 2021

Found the issue here, this class is the one handling the keyboard controls and checking if a key is pressed https://github.com/openworm/geppetto-client/blob/master/js/pages/geppetto/THREEx.KeyboardState.js . It's not detecting when the Shift key is let go after being pressed, looking for a fix

jrmartin added a commit that referenced this issue Jul 15, 2021
jrmartin added a commit that referenced this issue Jul 15, 2021
@jrmartin jrmartin linked a pull request Jul 21, 2021 that will close this issue
2 tasks
Robbie1977 added a commit that referenced this issue Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug MetaCell Jobs for metacell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants