Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML #62

Closed
nixbedman opened this issue Jun 1, 2021 · 9 comments
Closed

HTML #62

nixbedman opened this issue Jun 1, 2021 · 9 comments
Assignees
Labels
bug Something isn't working needs-testing needs some tests

Comments

@nixbedman
Copy link

Hello. Removes the body from the letter. Receive an alert from a third-party site jivosite.ru, mail2most transmits only the header. Please help me. thank you.
Changed settings, same error (SubjectOnly = false):
StripHTML
ConvertToMarkdown

time="2021-06-01T07:01:30+06:00" level=error msg="Mattermost Post Error" error=": Неверные идентификаторы файлов. Обратите внимание, что загрузка ограничена максимум 5 файлами. Пожалуйста, используйте дополнительные сообщения для большего количества файлов., " status="fallback send only subject"

@c-seeger
Copy link
Contributor

c-seeger commented Jun 1, 2021

hello @nixbedman and thank you for your issue.
Can you describe the issue a bit more please?

You get a mail from jivosite.ru containing multiple attachments (as of the russian error message)?
It should be send to your Mattermost (which is russian language i think?) which does not work?

This is the error message (just for documentation):

Invalid file identifiers. Please note that downloads are limited to a maximum of 5 files. Please use additional posts for more files

So it seems that your mail contains more than 5 attachments and mattermost limits the amount of attachments to 5 (is this a configuration or a hard value?).

Mail2Most has the option MailAttachments, you can test to set this to false. No attachments will be forwarded to mattermost then which should prevent the error for now.

I'll do some research if the 5 attachment limit is a hard or configured one and check if i can reproduce this problem.

@c-seeger c-seeger self-assigned this Jun 1, 2021
@c-seeger c-seeger added bug Something isn't working needs-testing needs some tests labels Jun 1, 2021
@nixbedman
Copy link
Author

nixbedman commented Jun 1, 2021

Thanks for being quick. The letter contains HTML. It's got pictures. I can forward the email to you. MailAttachments false does not help. 5 files is a Mattermost constraint.

Download is limited to a maximum of 5 files. Please use additional messages to send more files.
изображение
mail jivosite
изображение

@c-seeger
Copy link
Contributor

c-seeger commented Jun 1, 2021

I've added the limit to the code please test if it helps. The implementation now only send the first 5 attachments the rest is ignored for now.

windows-amd64.tar.gz
windows-386.tar.gz
linux-arm64.tar.gz
linux-arm.tar.gz
linux-amd64.tar.gz
linux-386.tar.gz

@c-seeger
Copy link
Contributor

c-seeger commented Jun 1, 2021

I now properly fixed the maximum of 5 attachments issue. Mail2Most will now recognize if there are more than 5 attachments and will create multiple posts.
The first one will contain the normal configured output all other only containing the From header (if configured) + additional attachments in correct order of the posts. Please test the following build.

linux-arm64.tar.gz
linux-arm.tar.gz
linux-amd64.tar.gz
linux-386.tar.gz
windows-386.tar.gz
windows-amd64.tar.gz

@nixbedman
Copy link
Author

Thanks.
Messages now come to the chat.
Commands do not affect the display of the letter, and attachments still come:
ConvertToMarkdown
StripHTML
MailAttachments

@c-seeger
Copy link
Contributor

c-seeger commented Jun 2, 2021

Great i'll merge the fix and build a new release. Thank you @nixbedman very much for finding this issue and help making mail2most better.

@c-seeger c-seeger closed this as completed Jun 2, 2021
@nixbedman
Copy link
Author

Thank you so much for such a wonderful product.
Waiting to test.

1 similar comment
@nixbedman
Copy link
Author

Thank you so much for such a wonderful product.
Waiting to test.

c-seeger added a commit that referenced this issue Jun 2, 2021
@c-seeger
Copy link
Contributor

c-seeger commented Jun 2, 2021

latest release can be found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-testing needs some tests
Projects
None yet
Development

No branches or pull requests

2 participants