Skip to content
Module CI

VCST-430: Simplify event handlers registration #67

Sign in to view logs

VCST-430: Simplify event handlers registration

VCST-430: Simplify event handlers registration #67

Triggered via pull request March 4, 2024 21:39
@artem-dudarevartem-dudarev
opened #19
VCST-430
Status Success
Total duration 2m 19s
Artifacts –

module-ci.yml

on: pull_request
ci
2m 10s
ci
module-katalon-tests  /  e2e-tests
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Core/Extensions/DomainEventExtensions.cs(21,49): warning S1067: Reduce the number of conditional operators (5) used in the expression (maximum allowed 3). (https://rules.sonarsource.com/csharp/RSPEC-1067) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Core/VirtoCommerce.EventBusModule.Core.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/Model/SubscriptionEventEntity.cs(21,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/VirtoCommerce.EventBusModule.Data.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/Model/SubscriptionEventEntity.cs(37,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/VirtoCommerce.EventBusModule.Data.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/Model/SubscriptionEntity.cs(26,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/VirtoCommerce.EventBusModule.Data.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/Model/SubscriptionEntity.cs(47,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/VirtoCommerce.EventBusModule.Data.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/Services/AzureEventBusProvider.cs(98,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data/VirtoCommerce.EventBusModule.Data.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data.SqlServer/Migrations/20220801055026_Initial2.cs(10,33): warning S138: This method 'Up' has 134 lines, which is greater than the 80 lines authorized. Split it into smaller methods. (https://rules.sonarsource.com/csharp/RSPEC-138) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data.SqlServer/VirtoCommerce.EventBusModule.Data.SqlServer.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data.MySql/Migrations/20221212201321_Initial.cs(10,33): warning S138: This method 'Up' has 109 lines, which is greater than the 80 lines authorized. Split it into smaller methods. (https://rules.sonarsource.com/csharp/RSPEC-138) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Data.MySql/VirtoCommerce.EventBusModule.Data.MySql.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Web/Controllers/Api/SubscriptionsController.cs(78,57): warning S2589: Remove this unnecessary check for null. (https://rules.sonarsource.com/csharp/RSPEC-2589) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Web/VirtoCommerce.EventBusModule.Web.csproj]
ci
/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Web/Controllers/Api/SubscriptionsController.cs(78,57): warning S2583: Remove this unnecessary check for null. Some code paths are unreachable. (https://rules.sonarsource.com/csharp/RSPEC-2583) [/home/runner/work/vc-module-event-bus/vc-module-event-bus/src/VirtoCommerce.EventBusModule.Web/VirtoCommerce.EventBusModule.Web.csproj]