fix: losing aliasMap in 'partial' subqueries #2405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from ovos#13
This fixes an issue with 'partial' subqueries that they lose
aliasMap
fromq._context
(QueryBuilder's "internal context") while generating nestedwhere
sql part.QueryBuilder.subqueryOf()
used to grab context from "parent" query, but it doesn't anymore. (since 2019-02-13) 524e0beIn our case, we were getting SQL errors where alias was necessary to make it work, but it was missing
Basically reintroducing what was deleted in 524e0be (to fix #1205) but wrap merging context with a condition that it should only apply to "partial" subqueries + reverse the sequence that
isPartial()
is set beforesubqueryOf()