loosen the JSONSchema typings allow any string in

Vincit · Jan 6, 2020 · 78bf469 · 78bf469
1 parent d247fc9
commit 78bf469
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/tests/ts/examples.ts b/tests/ts/examples.ts
@@ -62,12 +62,12 @@ class Person extends objection.Model {
 
   static columnNameMappers = objection.snakeCaseMappers();
 
-  static jsonSchema: JSONSchema = {
+  static jsonSchema = {
     type: 'object',
 
     properties: {
       firstName: {
-        type: 'string'
+        type: 'string',
       }
     }
   };

diff --git a/typings/objection/index.d.ts b/typings/objection/index.d.ts
@@ -1352,9 +1352,7 @@ declare namespace Objection {
     new (): T;
   }
 
-  export interface ModelConstructor<M extends Model> extends Constructor<M> {
-
-  }
+  export interface ModelConstructor<M extends Model> extends Constructor<M> {}
 
   export interface ModelClass<M extends Model> extends ModelConstructor<M> {
     QueryBuilder: typeof QueryBuilder;
@@ -1812,7 +1810,9 @@ declare namespace Objection {
     | 'boolean'
     | 'object'
     | 'array'
-    | 'null';
+    | 'null'
+    | string;
+
   export type JSONSchemaType = JSONSchemaArray[] | boolean | number | null | object | string;
 
   // Workaround for infinite type recursion