Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with languages like german #15

Merged
merged 1 commit into from Nov 25, 2020
Merged

Compatibility with languages like german #15

merged 1 commit into from Nov 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2019

Some languages doesn't have a single plural letter.

@VincentLoy
Copy link
Owner

Hello @q30t !
Thanks a lot for your contribution. I'll merge this PR after some tests.
Also I have to make a change in YACP (https://github.com/VincentLoy/YACP) That is basically a port of simplyCountdown for Wordpress. The Wordpress plugin is using the current way of how simplyCountdown manage plural words.

So, this change must be done in both plugins. I'll let you know when done.

Thanks a lot for your contribution !

@VincentLoy VincentLoy merged commit 4d060f4 into VincentLoy:master Nov 25, 2020
@VincentLoy
Copy link
Owner

Hi @q30t ! Merged ! Thanks a lot for your contribution 😃

@VincentLoy VincentLoy mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VincentLoy