Added support for managing number replays & removing childViews #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaweesi
changed the title
hendrawd
reviewed
May 20, 2022
| @@ -76,6 +76,12 @@ for (int index = 0; index < 50; index++) { | |||
| tickerView.addChildView(tv); | |||
| } | |||
|
|
|||
| // Call setReplays(replays) to set numper of times to loop/scroll entire messages | |||
Comment on lines
+40
to
+41
| private Integer replays; | ||
| private Integer loop = 1; |
There was a problem hiding this comment.
Use primitive type for better memory usage?
Suggested change
| private Integer replays; | |
| private Integer loop = 1; | |
| private int replays; | |
| private int loop = 1; |
Comment on lines
+149
to
+151
| /** | ||
| * | ||
| */ |
|
|
||
| private Integer replays; | ||
| private Integer loop = 1; | ||
| private boolean replaysCompleted = false; |
There was a problem hiding this comment.
Can remove explicit assignment to false since it's already the default value
Suggested change
| private boolean replaysCompleted = false; | |
| private boolean replaysCompleted; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.