Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [feature]: Grid Layout of Campgrounds #150

Conversation

MitulSonagara
Copy link

📋 Description

I have fixed the campground layout using grid layout

🔨 Changes Made

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings.
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

  • Bug fix (non-breaking change which fixes an issue) 🐛
  • New feature (non-breaking change which adds functionality) ✨
  • UI enhancement (non-breaking change which enhances UI) 🎨
  • Documentation update 📚

🤝 Related Issues

📸 Screenshots (if applicable)

Reminder:

Please ensure your pull request is made to the test branch, not main.

Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

@MitulSonagara
Copy link
Author

@Vignesh025

Please review this and merge it

@Vignesh025
Copy link
Contributor

It's still the same. Everything is breaking.

@MitulSonagara
Copy link
Author

@Vignesh025

this is working fine on my local system
image

i didnt uploaded the pics thats why it is looking like this

@Vignesh025
Copy link
Contributor

Vignesh025 commented Oct 13, 2024

this is working fine on my local system

Look at the navbar
compare it with the deployed website
you can see the difference
also appearance wise we can see some padding changes

@MitulSonagara
Copy link
Author

@Vignesh025

only navbar issue is there?

@Vignesh025
Copy link
Contributor

only navbar issue is there?

There are few padding issues as well. If you check it with the deployed website, you'll notice.

@MitulSonagara
Copy link
Author

@Vignesh025

Ya i know but i changed some padding suitable for the grid layout

@Vignesh025
Copy link
Contributor

Hey, the grid layout is not properly responsive. Here are the changes needed:

Below 580px: 1 card per row
From 580px to 780px: 2 cards per row
From 780px to 1024px: 3 cards per row
Above 1024px: 4 cards per row
Also, there are some UI issues:

The sort button's UI is breaking
The search button's UI breaks after a search
The dropdown button on mobile screens is also breaking
The padding change you made on the campgrounds page is affecting the view page
The 'View' button inside each card should be positioned at the bottom of the box
Please address these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants