Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference error in ol-ext 4.0.19 #1085

Closed
SebastianBock83 opened this issue Jul 15, 2024 · 5 comments
Closed

Reference error in ol-ext 4.0.19 #1085

SebastianBock83 opened this issue Jul 15, 2024 · 5 comments
Labels

Comments

@SebastianBock83
Copy link

SebastianBock83 commented Jul 15, 2024

Hello,

When using version 4.0.19 of ol-ext we got some reference errors when using the LayerSwitcher import.

The error message is that
image

I am using webpack to compile my package and node version 20.11.1.
Due to lack of access to some code online tools, I am not able to provide an example here.

I only can say that ol-ext version 4.0.18 is working.
Based on the semantic versioning specification the bugfix to 4.0.19 should not cause breaking changes, so that I think that this is a bug in the library.

If you need further information, don't hesitate to ask and I will provide you as much as I can.

Best Regards,
Sebastian

@Viglino
Copy link
Owner

Viglino commented Jul 15, 2024

You have to install Openlayers in your project.

npm install ol

Ol is a peer dependency in ol-ext, you should have a warning on your console. It let's you install the ol version you want.

@SebastianBock83
Copy link
Author

@Viglino of course we have Openlayers defined as dependency with version ^9.0.0. As mentioned in my first post, with 4.0.18 everything worked fine and the update to 4.0.19 breaks our package builds.

Viglino added a commit that referenced this issue Jul 16, 2024
@Viglino
Copy link
Owner

Viglino commented Jul 16, 2024

You're right the file extension was missing...
Fixed in the last commit

@SebastianBock83
Copy link
Author

@Viglino thanks for fixing this so fast.
We are looking forward for the next release :-)

Best Regards,
Sebastian

@Viglino
Copy link
Owner

Viglino commented Jul 17, 2024

ol@4.0.20 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants