Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slots V2 #503

Merged
merged 41 commits into from
Dec 9, 2020
Merged

Slots V2 #503

merged 41 commits into from
Dec 9, 2020

Commits on Dec 9, 2020

  1. Implement slotable v2 

    * `with_slot` is now `renders_one`
* `with_slot collection: true` is now `renders_many`
* Slots are no longer stand-alone classes, but are lambdas that return
  an object that responds to `render_in` or a string
* Add support for positional arguments in slots v2
* Abstract away `slot.content`, preferring `to_s` (implicit or explicit)
* Replace `#slot` API with an API using the slots name. e.g.
  `c.slot(:header, 1)` is now `c.header(1)`
    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b42d85a View commit details
    Browse the repository at this point in the history

  2. Implement respond_to_missing?

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    c15fb7f View commit details
    Browse the repository at this point in the history

  3. Add respond_to_missing? test

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    13608bb View commit details
    Browse the repository at this point in the history

  4. Add nested component

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    9ccb996 View commit details
    Browse the repository at this point in the history

  5. Add info to nested component template lookup code

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    a1a93cc View commit details
    Browse the repository at this point in the history

  6. Remove unused benchmark components

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    cda4843 View commit details
    Browse the repository at this point in the history

  7. Re-rename subcomponents to slotablev2 

    The name didn't really work as well
    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    14e231d View commit details
    Browse the repository at this point in the history

  8. Feedback

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    c42febc View commit details
    Browse the repository at this point in the history

  9. Start working on docs

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    3bd29fb View commit details
    Browse the repository at this point in the history

  10. erb for docs

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b0c08e8 View commit details
    Browse the repository at this point in the history

  11. Fix slot types links

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    ca13216 View commit details
    Browse the repository at this point in the history

  12. markdown linter fixes

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    d9b05f2 View commit details
    Browse the repository at this point in the history

  13. small wording changes

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    68b7730 View commit details
    Browse the repository at this point in the history

  14. revert Gemfile.lock

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1cf8165 View commit details
    Browse the repository at this point in the history

  15. Update docs/index.md 

    Co-authored-by: halo <halo@users.noreply.github.com>
    @BlakeWilliams @halo
    BlakeWilliams and halo committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    0ae7de8 View commit details
    Browse the repository at this point in the history

  16. Update docs/index.md 

    Co-authored-by: halo <halo@users.noreply.github.com>
    @BlakeWilliams @halo
    BlakeWilliams and halo committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    c0d3ec8 View commit details
    Browse the repository at this point in the history

  17. Update docs/index.md 

    Co-authored-by: halo <halo@users.noreply.github.com>
    @BlakeWilliams @halo
    BlakeWilliams and halo committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    77a4e41 View commit details
    Browse the repository at this point in the history

  18. Update docs/index.md 

    Co-authored-by: halo <halo@users.noreply.github.com>
    @BlakeWilliams @halo
    BlakeWilliams and halo committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    4344730 View commit details
    Browse the repository at this point in the history

  19. Update bundle

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    8e94e20 View commit details
    Browse the repository at this point in the history

  20. Add collection rendering support to collection slots

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    cf3f60c View commit details
    Browse the repository at this point in the history

  21. Move slots v1 documentation

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    5742a82 View commit details
    Browse the repository at this point in the history

  22. Basic collection rendering example

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    8accde7 View commit details
    Browse the repository at this point in the history

  23. Move section up

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    6e87fbc View commit details
    Browse the repository at this point in the history

  24. markdown lint fixes

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    12b823a View commit details
    Browse the repository at this point in the history

  25. Apply suggestions from code review 

    Co-authored-by: Joel Hawksley <joelhawksley@github.com>
    @BlakeWilliams @joelhawksley
    BlakeWilliams and joelhawksley committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    dca91dd View commit details
    Browse the repository at this point in the history

  26. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    7d7eb36 View commit details
    Browse the repository at this point in the history

  27. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    902f847 View commit details
    Browse the repository at this point in the history

  28. Apply suggestions from code review 

    Co-authored-by: Joel Hawksley <joelhawksley@github.com>
    @BlakeWilliams @joelhawksley
    BlakeWilliams and joelhawksley committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    15adb43 View commit details
    Browse the repository at this point in the history

  29. Apply suggestions from code review 

    Co-authored-by: Joel Hawksley <joelhawksley@github.com>
    @BlakeWilliams @joelhawksley
    BlakeWilliams and joelhawksley committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    6eededa View commit details
    Browse the repository at this point in the history

  30. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b33481d View commit details
    Browse the repository at this point in the history

  31. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e1a388b View commit details
    Browse the repository at this point in the history

  32. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    11aee3f View commit details
    Browse the repository at this point in the history

  33. Update docs/index.md

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    234d3d7 View commit details
    Browse the repository at this point in the history

  34. Fix up docs, add link to v2 docs

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    cc3e134 View commit details
    Browse the repository at this point in the history

  35. Apply suggestions from code review 

    Co-authored-by: Joel Hawksley <joelhawksley@github.com>
    @BlakeWilliams @joelhawksley
    BlakeWilliams and joelhawksley authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e4e6791 View commit details
    Browse the repository at this point in the history

  36. Add changelog entry

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1b0884c View commit details
    Browse the repository at this point in the history

  37. Add slotablev2 include for each slot

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    5bd0138 View commit details
    Browse the repository at this point in the history

  38. Fix indentation

    @BlakeWilliams
    BlakeWilliams committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    efece69 View commit details
    Browse the repository at this point in the history

  39. Markdown formatting 

    Co-authored-by: Joel Hawksley <joelhawksley@github.com>
    @BlakeWilliams @joelhawksley
    BlakeWilliams and joelhawksley authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    21c0075 View commit details
    Browse the repository at this point in the history

  40. Update CHANGELOG.md

    @joelhawksley
    joelhawksley authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    2704506 View commit details
    Browse the repository at this point in the history

  41. Update CHANGELOG.md

    @BlakeWilliams
    BlakeWilliams authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    333c0d0 View commit details
    Browse the repository at this point in the history