Skip to content

Renaming content to children #539

Discussion options

You must be logged in to vote

I like the idea of renaming content.

My only nitpick is that react's children returns an array of components and we return a string. I wonder if something like block_content might help clarify that it's coming from the block given when rendered, but is also a string?

Semi-related: I have been wondering if we could utilize yield instead of assigning to an ivar/accessor which would eliminate the name completely from the public API. But there's trade-offs there and that might be a separate discussion. 😄

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@jaredcwhite
Comment options

Answer selected by BlakeWilliams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Ideas
Labels
None yet
3 participants