Update predefined macros #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
reviewed
Sep 12, 2021
test/runner.zig
Outdated
| var skip_count: u32 = 0; | ||
| for (cases.items) |range| { | ||
| // prepare compiler | ||
| var comp = aro.Compilation.init(gpa); |
There was a problem hiding this comment.
If you added a builtin field to Source.Id only it would need to be regenerated and all other loaded files would remain. This could also be used to clean a bunch of magic numbers in Compilation.
ehaas
force-pushed
the
predefined-macros
branch
2 times, most recently
from
96db12b to
a4d95d2
Compare
|
Updated it to use the epoch API you linked, for when that gets merged. I changed the way the test runner handles the predefined macros but I'm not entirely sure about what you mean regarding removing the magic numbers from |
ehaas
force-pushed
the
predefined-macros
branch
from
a4d95d2 to
e109ae1
Compare
Vexu
force-pushed
the
predefined-macros
branch
from
e109ae1 to
8afe7c3
Compare
|
Thanks! I fixed a small off-by-one error in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct value of
__STDC_VERSION__Add placeholder values for
__DATE__and__TIME__Update test runner to create a new compilation for each test since the predefined macros can change based on the test.