Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing genres #4

Closed
lstres opened this issue Feb 17, 2024 · 37 comments
Closed

Not showing genres #4

lstres opened this issue Feb 17, 2024 · 37 comments

Comments

@lstres
Copy link

lstres commented Feb 17, 2024

The extension isn't working including the original spotify genres, it shows that music icon to toggle genres but it is not showing any genre. Here is a screenshot
image
and the image when the genres are on
image
So as you can see the liked button and music button is pushed to side by 10 pixels.
That's the only visual change I can notice

EDIT: One more thing, I have this problem for a pretty long time now, but after i reinstalled my windows 11 and downloaded spotify then spicetify. It was working again now it is not. It has been only 2 weeks i guess

@lstres
Copy link
Author

lstres commented Feb 17, 2024

I have also tried installing it manually, still the same issue

@matthewyuc
Copy link

same problem

@Vexcited
Copy link
Owner

Seems like Spotify changed something in the layout so it just won't appear, I'll look into this this afternoon!

@lstres
Copy link
Author

lstres commented Feb 17, 2024

Thanks, btw now I can say that I got this bug after updating spotify about 2 days ago

@Vexcited
Copy link
Owner

Hm, sadly I can't reproduce it on my Spotify installation on Linux, I tried to upgrade everything but it seems like I don't have anything breaking on my side...

image

If anyone can show what the HTML of the player info container looks like (with devtools), I would be very useful !

@lstres
Copy link
Author

lstres commented Feb 17, 2024

image
here is a screenshot, btw you've got a nice desktop setup

@lstres
Copy link
Author

lstres commented Feb 17, 2024

image
it seems like this thing have to do something with the genres, html isn't my thing lol

@Vexcited
Copy link
Owner

Thanks! Well, there's no update in the layout and it in fact works perfectly the way it should...

The only issue is that tags aren't pushed to the <div ... grid-area: genres ...></div> that I create manually 🤔

Is anything showing in the console when you change songs ? Like an error ?

@lstres
Copy link
Author

lstres commented Feb 17, 2024

image
changing doesn't give any error, but these are some previous errors

@Vexcited
Copy link
Owner

Hm, it's not related sadly...

@Vexcited
Copy link
Owner

Let me try to write a custom extension for your case with a bunch of console.log everywhere to see where it hangs 😭

@lstres
Copy link
Author

lstres commented Feb 17, 2024

that seems like a lot of work ig, no hurry from me. I didn't even notice this but today when I wanted to see the genre of a new song. Thanks for maintaining this extension ❤️

@Vexcited
Copy link
Owner

Can you please try with this one and screen whatever shows up in logs ?
https://drive.google.com/file/d/1qjdeTiisyOEoOXHw-oLQ69AXfrepMzY8/view?usp=sharing

Thanks you!

@lstres
Copy link
Author

lstres commented Feb 17, 2024

can I just replace the genres file in extensions? I actually tried installing it manually.

@Vexcited
Copy link
Owner

Yes you should do it that way, and reload the spicetify plugins after

@lstres
Copy link
Author

lstres commented Feb 17, 2024

image
here it is

@lstres
Copy link
Author

lstres commented Feb 17, 2024

this at the last
image

@Vexcited
Copy link
Owner

Alright, I kinda see what's going on now, let me see what I can do on my end

@Vexcited
Copy link
Owner

Vexcited commented Feb 17, 2024

I would need more info (again) because I don't see why it would fail !
All of the following should be ran in DevTools while on Spotify (when you're playing a song)

  1. Spicetify.Player.data.item.metadata.artist_uri what's the output ?
  • You should have something looking like this spotify:artist:xxxxxxxxxxxxxxxxxxxxx
  1. Now save the xxxxxxxxxxxxxxxxxxxxx part from 1. and drop it in the following command : await Spicetify.CosmosAsync.get("https://api.spotify.com/v1/artists/xxxxxxxxxxxxxxxxxxxxx"), replacing xxxxxxxxxxxxxxxxxxxxx by the ID from part 1.

If everything went well you should be able to see genres in the output, like this :
image

If all the commands worked well, then this issue is mysterious because that's literally the process I use to have genres in the extension, so if you can do it all by hand there's no reason the extension can't do it !

@Switchbladd
Copy link

Switchbladd commented Feb 18, 2024

image
Same error for any artist & for random symbols too
Artist's page normally opens in browser with same artist url so idk
Edit: spotify info
image

@lstres
Copy link
Author

lstres commented Feb 18, 2024

  1. The output is 'spotify:artist:7Ln80lUS6He07XvHI8qqHH'
  2. I got an error instead of receiving genres:
    image
    it was 1 am for me yesterday so I had to sleep that's why pretty late. ig we have a big time difference

@Vexcited
Copy link
Owner

Wow ok, so both of you all got this error ...

Just checked Spicetify issues and found this spicetify/cli#1537 (comment)

Feels like I'd need to find a workaround for this case

@Switchbladd
Copy link

Switchbladd commented Feb 18, 2024

image
spicetify/cli#2844 Looks like all CosmosAsync extensions died, so you & we prolly just need to wait for their solution/response
Edit: strange that it works for you, what's your spotify version?

@Vexcited
Copy link
Owner

Vexcited commented Feb 18, 2024

For now, I pushed yesterday a "fix" that uses Last.FM genres instead of Spotify's genres from artists : 5e5c3fe

The sad thing is that it covers way less songs but works for popular ones.

I'll lookup for an alternative request and will add my solution here if I find one !

In the meantime, use the latest version with Last.FM genres (sorry for the waiting)

@Vexcited
Copy link
Owner

What's your spotify version?

image

Seems like the Linux repository is locked at version 1.2.26.1187 for now : see http://repository.spotify.com/dists/testing/non-free/binary-amd64/Packages

That's why I don't have this issue yet, wonder when Spotify will upgrade their repository...

@lstres
Copy link
Author

lstres commented Feb 18, 2024

so do we need to downgrade?
it will update automatically again 😂

@Vexcited
Copy link
Owner

Vexcited commented Feb 18, 2024

If you do want to have it absolutely working right now, yes downgrading is the only option, but as I said, I'll try to find another alternative to get those genres somehow...

Also, the push I did for using Last.FM genres should work for all versions, so you can still have some genres (if the artist is not unknown 😭)... You just won't have the Spotify fallback, sadly

(Build for the Last.FM push : https://github.com/Vexcited/better-spotify-genres/blob/e3dbc344727694c96e841dbd7a97410c9b0de50c/spotifyGenres.js)

@lstres
Copy link
Author

lstres commented Feb 18, 2024

thx for the last fm build, i'm sure there will be some other way

@rxri
Copy link

rxri commented Feb 20, 2024

hiya, v2.32.0 should fix this issue. It has been resolved by spicetify/cli#2846

@lstres
Copy link
Author

lstres commented Feb 20, 2024

Thanks for telling ❤️

@Vexcited
Copy link
Owner

No way ! So everything works like before for you all now ?

If yes, then I'll let the OP close the issue :')

@lstres
Copy link
Author

lstres commented Feb 21, 2024

for me, it does work like before

@lstres lstres closed this as completed Feb 21, 2024
@lstres lstres reopened this Feb 21, 2024
@lstres
Copy link
Author

lstres commented Feb 21, 2024

accidently closed, sorry 😅

@Vexcited
Copy link
Owner

I mean, if anybody else don't have the issue anymore too, you can close it !

If someone faces again this issue, they'll probably write it here (so I'll just reopen it) or open a new issue

Thanks !

@stebo02
Copy link

stebo02 commented Feb 21, 2024

It works but now it's showing Last FM tags in favour of genres:

Screenshot 2024-02-21 113549

Screenshot 2024-02-21 113620

It seems to only show the genres in the player bar when there's no Last FM tags available.

@Vexcited
Copy link
Owner

True! Will revert this behavior in the afternoon, sorry for the inconvenience

Vexcited added a commit that referenced this issue Feb 22, 2024
@Vexcited
Copy link
Owner

@stebo02 done ! Update your extension and it should be back like before.

Re-implemented in 48dea10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants