Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for Base.empty #24

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Add method for Base.empty #24

merged 1 commit into from
Dec 24, 2023

Conversation

eliascarv
Copy link
Contributor

closes #22

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21a55c2) 100.00% compared to head (6ec8c3f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           47        48    +1     
=========================================
+ Hits            47        48    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vexatos
Copy link
Owner

Vexatos commented Dec 24, 2023

Thanks, this looks good.

@Vexatos Vexatos merged commit 1ae9608 into Vexatos:master Dec 24, 2023
11 checks passed
@eliascarv eliascarv deleted the empty branch December 24, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong fallback for Base.empty
2 participants