Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump mime from 1.0.6 to 2.0.0 in /packages/dart_frog #1528

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2024

Bumps mime from 1.0.6 to 2.0.0.

Release notes

Sourced from mime's releases.

package:mime v2.0.0

  • [Breaking] extensionFromMime(String mimeType) returns null instead of mimeType for an unknown mime type.
  • Update extensionFromMime to return a default extension when a MIME type maps to multiple extensions.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mime](https://github.com/dart-lang/tools/tree/main/pkgs) from 1.0.6 to 2.0.0.
- [Release notes](https://github.com/dart-lang/tools/releases)
- [Commits](https://github.com/dart-lang/tools/commits/mime-v2.0.0/pkgs)

---
updated-dependencies:
- dependency-name: mime
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 30, 2024 18:22
@dependabot dependabot bot added dart Pull requests that update Dart code external dependency Requires changes in an external dependency labels Sep 30, 2024
@tomarra
Copy link
Contributor

tomarra commented Oct 1, 2024

Looking for some feedback from @wolfenrain on this one as its a major version bump

@wolfenrain
Copy link
Member

Looking for some feedback from @wolfenrain on this one as its a major version bump

I think this is safe to merge, we will be backwards compatible for any versions people might use of mime already and the API that changed isn't something we are using currently.

@tomarra tomarra merged commit 898562f into main Oct 3, 2024
25 checks passed
@tomarra tomarra deleted the dependabot/pub/packages/dart_frog/mime-2.0.0 branch October 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code external dependency Requires changes in an external dependency
Projects
Development

Successfully merging this pull request may close these issues.

2 participants