chore: Allow protobuf < 4.0 to support M1 Macs #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuverta
changed the title
liuverta
commented
Jul 28, 2022
Comment on lines
-354
to
-360
| # List of optional constructs for which whitespace checking is disabled. `dict- | ||
| # separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. | ||
| # `trailing-comma` allows a space between comma and closing bracket: (a, ). | ||
| # `empty-line` allows space-only lines. | ||
| no-space-check=trailing-comma, | ||
| dict-separator | ||
|
|
There was a problem hiding this comment.
liuverta
commented
Jul 28, 2022
| @@ -285,7 +285,8 @@ ignored-classes=optparse.Values, | |||
| # (useful for modules/projects where namespaces are manipulated during runtime | |||
| # and thus existing member attributes cannot be deduced by static analysis. It | |||
| # supports qualified module names, as well as Unix pattern matching. | |||
| ignored-modules=verta._protos.* | |||
| ignored-modules=verta._protos.*, | |||
| google.protobuf.struct_pb2, | |||
There was a problem hiding this comment.
protobuf==3.20 deepens its dynamic generation shenanigans
which causes pylint check failures, unless explicitly ignored here.
conradoverta
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
We need to allow newer versions of
protobuf==3.*for M1 Mac support (airbytehq/airbyte#13624).This effectively reverts #2633, which was done because
protobuf==3.18.0broke Python 2 installs (protocolbuffers/protobuf#8984). Since then,protobuf==3.18.0has been yanked (protocolbuffers/protobuf#9045 (comment)) and theprotobufpackage metadata now specifiespython_requires(protocolbuffers/protobuf#8989), making this looser upper constraint safe again.Risks and Area of Effect
This once again puts us at the mercy of
protobufmaintainers ensuring API compatibility for3.*. But seeing as they've moved onto4.*now, I'd expect3.*to remain stable.Testing
I've manually verified that
pip2 install /path/to/modeldb/client/vertafrom this branch still installsprotobuf==3.17.3—a known safe version.I've also run the
registry/model_versiontests, which run the gamut ofprotobufusage, and there are no related failures.How to Revert
Revert this PR.