move back to UseShellExecute = true (#503)

VerifyTests · Jun 24, 2024 · 2ffd34b · 2ffd34b
1 parent d7ccb9e
commit 2ffd34b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/DiffEngine/DiffRunner.cs b/src/DiffEngine/DiffRunner.cs
@@ -216,7 +216,9 @@ static int LaunchProcess(ResolvedTool tool, string arguments)
         var startInfo = new ProcessStartInfo(tool.ExePath, arguments)
         {
             // Given the full exe path is known we dont need UseShellExecute https://stackoverflow.com/a/5255335
-            UseShellExecute = false
+            // however UseShellExecute allows the test running to not block when the difftool is launched
+            // https://github.com/VerifyTests/Verify/issues/1229
+            UseShellExecute = true
         };
         try
         {

diff --git a/src/DiffEngineTray/DiffToolLauncher.cs b/src/DiffEngineTray/DiffToolLauncher.cs
@@ -25,7 +25,9 @@ public static void Launch(TrackedMove move)
         var startInfo = new ProcessStartInfo(move.Exe!, move.Arguments!)
         {
             // Given the full exe path is known we dont need UseShellExecute https://stackoverflow.com/a/5255335
-            UseShellExecute = false
+            // however UseShellExecute allows the test running to not block when the difftool is launched
+            // https://github.com/VerifyTests/Verify/issues/1229
+            UseShellExecute = true
         };
 
         try

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;CS0649</NoWarn>
-    <Version>15.4.3</Version>
+    <Version>15.4.4</Version>
     <AssemblyVersion>1.0.0</AssemblyVersion>
     <PackageTags>Testing, Snapshot, Diff, Compare</PackageTags>
     <Description>Launches diff tools based on file extensions. Designed to be consumed by snapshot testing libraries.</Description>