Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot format ascii #392

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Dot format ascii #392

merged 1 commit into from
Mar 1, 2024

Conversation

koniksedy
Copy link
Collaborator

This PR includes:

  • Modification of the method Nft::print_to_DOT(), enabling it to translate EPSILON to <eps> and DONT_CARE to <dcare>.
  • Added functionality for methods Nfa::print_to_DOT() and `Nft::print_to_DOT(), allowing them to translate transition printable symbols (< 33) into ASCII.

I believe these modifications will make DOT graphs easier to understand.

@koniksedy koniksedy requested a review from Adda0 March 1, 2024 11:12
@koniksedy koniksedy closed this Mar 1, 2024
@koniksedy koniksedy reopened this Mar 1, 2024
@koniksedy koniksedy changed the base branch from devel to states_with_levels March 1, 2024 11:13
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 73.32%. Comparing base (be76747) to head (485b91e).
Report is 1 commits behind head on states_with_levels.

Files Patch % Lines
src/nft/nft.cc 0.00% 16 Missing ⚠️
src/nfa/nfa.cc 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           states_with_levels     #392      +/-   ##
======================================================
- Coverage               73.63%   73.32%   -0.31%     
======================================================
  Files                      43       43              
  Lines                    5150     5170      +20     
  Branches                 1166     1173       +7     
======================================================
- Hits                     3792     3791       -1     
- Misses                    921      942      +21     
  Partials                  437      437              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good. I will merge the PR so we can continue.

@Adda0 Adda0 merged commit ebf47e2 into states_with_levels Mar 1, 2024
40 of 44 checks passed
@Adda0 Adda0 deleted the DOT_format_ASCII branch March 1, 2024 11:31
Adda0 added a commit that referenced this pull request Mar 28, 2024
Adda0 added a commit that referenced this pull request Apr 15, 2024
Adda0 added a commit that referenced this pull request Nov 18, 2024
Adda0 added a commit that referenced this pull request Nov 21, 2024
Adda0 added a commit that referenced this pull request Nov 21, 2024
Adda0 added a commit that referenced this pull request Nov 22, 2024
Adda0 added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants