-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[Plugin] showBadgeInChat #2347
base: main
Are you sure you want to change the base?
Conversation
LGTM although will it show Nitro badges? (Boost, etc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and quite polished.
Yes |
…E.md to src/plugins/showBadgesInChat/README.md
….tsx to src/plugins/showBadgesInChat/index.tsx
…ngs.tsx to src/plugins/showBadgesInChat/settings.tsx
…s.css to src/plugins/showBadgesInChat/styles.css
I am very sorry, This is like my third time using github, but I fucked up and this was my attempt to fix it. I hope it work. 😭 |
I'm going to bump this because even tho it's lost in hell, I see at least one white name a day ask for a plug-in that does exactly this |
This comment was marked as spam.
This comment was marked as spam.
i hope this gets merged soon |
thank u for your kinda words i hope so too, Its almost everyday i see someone asking for plugin. So i also hope it gets merged too. <3 ;3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meow
Co-authored-by: vee <vendicated@riseup.net>
Co-authored-by: vee <vendicated@riseup.net>
Co-authored-by: vee <vendicated@riseup.net>
i think everything is fixed @Vendicated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for better maintainability and catching bugs before they occur, try to avoid using the any
type. here you already have strong types on everything so there's no reason to use all these anys
Mrrooww Co-authored-by: vee <vendicated@riseup.net>
ok committed |
misclicked, didnt mean to do that |
ok bug fix, thx @Inbestigator for spotting that |
@Inbestigator is a meanie whom keeps waking me up*(joke)*, forgot the style import earlier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge
Vee, it still says you have a change requested, but there is no change 💀 |
bumping this at the request of Inbestigator |
honestly after long forgetting about this plugin and pr, its updated to work with the |
supersedes the abandoned #1980 (Is also just complete rewrite of it)
Shows the message author's badges beside their name in chat.
The badges include all built-in Discord badges.
It also proudly displays your Vencord donor/contributor badges.
The settings editor lets you:
An example of what the menu looks like ↓
Vencord Creator: Vee (vending.machine) badge's ↓
Video of menu in action ↓
https://github.com/Vendicated/Vencord/assets/150982280/5ebc21cc-19dc-4cf9-b988-c95eae1f9ca5
Discord currently has a small bug where an author who isn't the current user will return their premiumType as undefined. There is nothing we can do about this until Discord fixes this bug