Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCert SDK - Adds ability to provision certificate using keystore and provider name #469

Merged
merged 4 commits into from
May 10, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

No description provided.

Copy link

@sbanic-venafi sbanic-venafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there examples that need to be added/modified, as well?

@luispresuelVenafi
Copy link
Contributor Author

luispresuelVenafi commented May 10, 2024

Are there examples that need to be added/modified, as well?

I did update this one here: https://github.com/Venafi/vcert/pull/469/files#diff-eb556c235da2917708a699331008cd6644dc5ea6baf700c247b35aede5f896a6

I kept the other example as ID because, well, we wanted to have both kind of examples for usage, one for Keystore ID and another for using both Keystore Name and Provider Name

@luispresuelVenafi luispresuelVenafi force-pushed the impr-certificate-provision branch from 5601aca to 4da9a9b Compare May 10, 2024 17:54
@luispresuelVenafi luispresuelVenafi merged commit bb54865 into master May 10, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the impr-certificate-provision branch May 10, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants